Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(samples): Fix the loop_output.py example to handle the new parallel loop type requirement #10637

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Mar 28, 2024

Description of your changes:
After PR #10494, all the parallel loop input type has to be List. The current loop_output.py example still output as str which causes the following errors:

Cannot iterate over a single parameter using `dsl.ParallelFor`. Expected a list of parameters as argument to `items`.

Thus, fix the loop_output.py example to output type List[str].

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Mar 28, 2024

/assign @connor-mccarthy

Copy link

@Tomcli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 db3dd62 link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@connor-mccarthy
Copy link
Member

/lgtm
/approve

Thank you, @Tomcli!

@google-oss-prow google-oss-prow bot added the lgtm label Mar 28, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@connor-mccarthy connor-mccarthy merged commit afddae9 into kubeflow:master Mar 28, 2024
2 of 4 checks passed
@Tomcli Tomcli deleted the patch-1 branch March 28, 2024 21:59
petethegreat pushed a commit to petethegreat/pipelines that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants