-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): Prevents dsl.ParallelFor over single parameter from compiling. #10494
fix(sdk): Prevents dsl.ParallelFor over single parameter from compiling. #10494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @KevinGrantLee!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Kevin!
Co-authored-by: Connor McCarthy <[email protected]>
Co-authored-by: Connor McCarthy <[email protected]>
Co-authored-by: Connor McCarthy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thank you, @KevinGrantLee!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest-required |
/retest |
@KevinGrantLee: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…ng. (kubeflow#10494) * fix(sdk): Prevents dsl.ParallelFor over single paramter from compiling. * fix(sdk): Prevents dsl.ParallelFor over single paramter from compiling. * update PR number in release notes * formatting * Add compiler_test.py test for single param compile failure * Update some docstrings and add todo * formatting * Update sdk/python/kfp/compiler/compiler_test.py Co-authored-by: Connor McCarthy <[email protected]> * Update sdk/python/kfp/compiler/compiler_test.py Co-authored-by: Connor McCarthy <[email protected]> * Update sdk/python/kfp/dsl/for_loop.py Co-authored-by: Connor McCarthy <[email protected]> * Use print_and_return and other small changes * typo * typo --------- Co-authored-by: Connor McCarthy <[email protected]>
…ng. (kubeflow#10494) * fix(sdk): Prevents dsl.ParallelFor over single paramter from compiling. * fix(sdk): Prevents dsl.ParallelFor over single paramter from compiling. * update PR number in release notes * formatting * Add compiler_test.py test for single param compile failure * Update some docstrings and add todo * formatting * Update sdk/python/kfp/compiler/compiler_test.py Co-authored-by: Connor McCarthy <[email protected]> * Update sdk/python/kfp/compiler/compiler_test.py Co-authored-by: Connor McCarthy <[email protected]> * Update sdk/python/kfp/dsl/for_loop.py Co-authored-by: Connor McCarthy <[email protected]> * Use print_and_return and other small changes * typo * typo --------- Co-authored-by: Connor McCarthy <[email protected]>
Description of your changes:
Prevents the following pipeline from compiling
The component
str_identity
outputs astr
so routing this todsl.ParallelFor
does not make sense.Checklist: