Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp-credentials volumes are added to workflow multiple times #494

Closed
Ark-kun opened this issue Dec 6, 2018 · 3 comments
Closed

gcp-credentials volumes are added to workflow multiple times #494

Ark-kun opened this issue Dec 6, 2018 · 3 comments
Assignees
@Ark-kun
Labels
area/sdk/dsl/compiler kind/bug priority/p1

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 6, 2018 •
edited
Loading

From our Kubeflow sample:

  volumes:
  - name: gcp-credentials
    secret:
      secretName: user-gcp-sa
  - name: gcp-credentials
    secret:
      secretName: user-gcp-sa
  - name: gcp-credentials
    secret:
      secretName: user-gcp-sa
  - name: gcp-credentials
    secret:
      secretName: user-gcp-sa
@Ark-kun Ark-kun mentioned this issue Dec 18, 2018
Closed
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 18, 2018

Proper way to fix this is to dedup based on the volume itself, not the name. Then, if we have name conflicts, we should change the volume.name+volumeMount.name (we have to do that when processing a task (ContainerOp), because later we won't know which volume is used by which volumeMount).

One solution to this is to have a method like task.add_mounted_volume(volume, volume_mount) which will automatically set the volume name to volume structure hash. That way different volumes will get different names and same volumes will get same names.

@Ark-kun Ark-kun mentioned this issue Dec 18, 2018
Merged
@vicaire vicaire assigned Ark-kun and unassigned IronPan, gaoning777 and qimingj Mar 26, 2019
@vicaire
Copy link
Contributor

vicaire commented Mar 26, 2019

Is this fixed by your PR? Can this be closed?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Aug 6, 2019

Duplicate volumes are no longer added

@Ark-kun Ark-kun closed this as completed Aug 6, 2019
@Ark-kun Ark-kun mentioned this issue Aug 6, 2019
Closed
Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@jlewi @k8s-ci-robot
Revert "Revert "Support subdirectories for junit files and grouping i…
f8302c8 
…n test grid by name (kubeflow#490)" (kubeflow#493)" (kubeflow#494)

This reverts commit 81326be.

* Relates to kubeflow#489

* Roll forward the orginal change now that kfctl_create_e2e_workflow.py
  has been updated to handle the extra argument.

add a leading /
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@pugangxa
Fix the copy result issue when it's already tekton result path (kubef…
7c1e4ec 
…low#494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ark-kun Ark-kun

Labels
area/sdk/dsl/compiler kind/bug priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Ark-kun @IronPan @gaoning777 @qimingj @vicaire