Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check volume uniqueness by content, not name #1746

Closed
Ark-kun opened this issue Aug 6, 2019 · 1 comment
Closed

Check volume uniqueness by content, not name #1746

Ark-kun opened this issue Aug 6, 2019 · 1 comment

Comments

@Ark-kun
Copy link
Contributor

Ark-kun commented Aug 6, 2019

Related to #494 (comment)
Volumes should be deduplicated based on the volume itself, not the name. Then, if we have name conflicts, we should change the volume.name+volumeMount.name (we have to do that when processing a task (ContainerOp), because later we won't know which volume is used by which volumeMount).

One solution to this is to have a method like task.add_mounted_volume(volume, volume_mount) which will automatically set the volume name to volume structure hash. That way different volumes will get different names and same volumes will get same names.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 12, 2019

The issue was resolved by #2229

@Ark-kun Ark-kun closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants