Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for katib mysql #2983

Closed

Conversation

pedrovgp
Copy link

@pedrovgp pedrovgp commented Feb 7, 2025

This is actually from this PR, which I accidentally closed when trying to add the tests only.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

/ok-to-test

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Feb 7, 2025

You should use 300-600s as timeout instead of 5s and add the changes from the previous PR and kubeflow/katib#2510

@juliusvonkohout juliusvonkohout added this to the 1.10 milestone Feb 7, 2025
@pedrovgp
Copy link
Author

pedrovgp commented Feb 7, 2025

@juliusvonkohout, I could not reproduce the problem with Kind. And even in the cluster I was testing, the problem did not happen again. I believe the deployment of katib-mysql failed in the previous attempt, and that led to the investigation I mentioned. I'll close this one for now, and I'll re-open if we find anything new.

Thanks for guidance.

@pedrovgp pedrovgp closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants