FIX secrets and mysql app selector for kubeflow install #2510
+166
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pedro Viana <[email protected]>
pedrovgp
force-pushed
the
issue-2980-katib-db-manager
branch
from
0d2d278 to
36e18c7
Compare
pedrovgp
force-pushed
the
issue-2980-katib-db-manager
branch
from
b496f43 to
7c9a3c7
Compare
Signed-off-by: Pedro Viana <[email protected]>
pedrovgp
force-pushed
the
issue-2980-katib-db-manager
branch
from
7c9a3c7 to
8cc3427
Compare
| @@ -11,18 +11,16 @@ resources: | |||
| images: | |||
| - name: docker.io/kubeflowkatib/katib-controller | |||
| newName: docker.io/kubeflowkatib/katib-controller | |||
| newTag: latest | |||
| newTag: v0.17.0 | |||
There was a problem hiding this comment.
Is latest not the correct tag on the master branch?
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the original PR (with linked issue) that originated these changes.
FOR REVIEWERS: the first commit is the relevant one, the second is fixing deprecation warnings from patcheStrategicMerge and vars.