Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v1.1.0 AWS Kfdef manifests #1434

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Jul 29, 2020

Which issue is resolved by this Pull Request:
Resolves kubeflow/kubeflow#5022

Description of your changes:
Release AWS v1.1.0 Kfdef manifests.

We didn't use v1.1.0 tag in this kfdef manifest, the major reason is some of our manifest v3 changes and multi-user pipeline changes are not included in v1.1.0. We still like to ship these features and that's the reason we use v1.1-branch. This will be reflected on the docs in kuebflow/website as well.

After community plans to cut a

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 29, 2020

/hold

@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 29, 2020

/cc @PatrickXYS

@k8s-ci-robot k8s-ci-robot requested a review from PatrickXYS July 29, 2020 23:02
@PatrickXYS
Copy link
Member

/lgtm

@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 29, 2020

/approve
/hold cancel

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants