Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Kubeflow 1.1 kfdef files are missing from master #1555

Closed
thesuperzapper opened this issue Sep 15, 2020 · 5 comments
Closed

AWS Kubeflow 1.1 kfdef files are missing from master #1555

thesuperzapper opened this issue Sep 15, 2020 · 5 comments

Comments

@thesuperzapper
Copy link
Member

Currently, the following files are missing from master but are present in v1.1-branch, this means users may not be able to find them:

  • ./kfdef/kfctl_aws.v1.1.0.yaml
  • ./kfdef/kfctl_aws_cognito.v1.1.0.yaml

This relates to PR #1434 being into v1.1-branch rather than master.

@Jeffwan I assume you want to fix this?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.86
platform/aws 0.86

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@thesuperzapper
Copy link
Member Author

/assign @Jeffwan

@Jeffwan
Copy link
Member

Jeffwan commented Oct 8, 2020

#1560 This has been added back to master. Since user use manifest from pinned branch. This is not a problem but may confuse user

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/kfctl 0.56

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@Jeffwan
Copy link
Member

Jeffwan commented Oct 8, 2020

We can close this issue now

@Jeffwan Jeffwan closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants