Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note for deprecated ingress annotation #3749

Closed
wants to merge 3 commits into from
Closed

docs: Add note for deprecated ingress annotation #3749

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2da320e
docs: Add note for deprecated annotation
younsl Nov 26, 2024
9865ed6
Merge branch 'develop' into develop
chipzoller Nov 28, 2024
86c39b9
chore: Exclude informative comment on labels
younsl Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cost-analyzer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,9 @@ ingress:
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
annotations:
## Starting in kubernetes v1.18, `kubernetes.io/ingress.class` annotation is deprecated.
## Use `spec.ingressClassName` instead of this annotation.
## See: https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
paths: ["/"] # There's no need to route specifically to the pods-- we have an nginx deployed that handles routing
Expand Down
Loading