docs: Add note for deprecated ingress annotation #3749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Used on ingress, Starting in v1.18, this annotation is deprecated in favor of spec.ingressClassName. Signed-off-by: younsl <[email protected]>
cost-analyzer/values.yaml
Outdated
| @@ -693,9 +693,15 @@ ingress: | |||
| enabled: false | |||
| # className: nginx | |||
| labels: | |||
| ## Starting in kubernetes v1.18, `kubernetes.io/ingress.class` annotation is deprecated. | |||
There was a problem hiding this comment.
Not sure if this comment is valid for labels too.
There was a problem hiding this comment.
@mittal-ishaan I agreed. Resolved at 86c39b9.
* Not sure if this comment is valid for labels too. * Reviewed at #3749 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
kubernetes.io/ingress.class.Does this PR rely on any other PRs?
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Links to Issues or tickets this PR addresses or fixes
What risks are associated with merging this PR? What is required to fully test this PR?
How was this PR tested?
Have you made an update to documentation? If so, please provide the corresponding PR.