Pick #3645 into v2.4 #3649
Closed
Pick #3645 into v2.4 #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vingsRecommendationsAllowLists (#3645) * [ENG-2729] Add resource reference files for kubecostProductConfigs.savingsRecommendationsAllowLists
|
FYI you don't need to manually cherry pick any more. We use a bot to do that. All you have to do is request "forward-slash 'cherry-pick'" and the release branch. |
|
Thank you @chipzoller. Closing this PR to cherry-pick in the recommended way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
CP for #3645
Does this PR rely on any other PRs?
CP for #3645
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Users can refer to a set of resource files for every supported CSP (AWS, GCP, Azure) for the complete lists of supported instance types for custom allow lists in Savings Recommendations.
Links to Issues or tickets this PR addresses or fixes
https://kubecost.atlassian.net/browse/ENG-2653
What risks are associated with merging this PR? What is required to fully test this PR?
N/A; resource files
How was this PR tested?
N/A; resource files
Have you made an update to documentation? If so, please provide the corresponding PR.
Public docs PR: kubecost/docs#1123