-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-2729] Add resource reference files for kubecostProductConfigs.savingsRecommendationsAllowLists #3645
Conversation
@biancaburtoiu I think it would be best to include the relevant helm keys in these files so that these files could be cloned, modified, and used as a values file. |
5b9e926
to
456f64e
Compare
@srpomeroy I've modified each of the 3 files to include the corresponding keys - just double checking that's what you expected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @biancaburtoiu
cc: @jessegoodier in case you care about folder structure or anything else.
456f64e
to
f251330
Compare
…vingsRecommendationsAllowLists
f251330
to
53e09c9
Compare
…vingsRecommendationsAllowLists (#3645) * [ENG-2729] Add resource reference files for kubecostProductConfigs.savingsRecommendationsAllowLists
/cherry-pick v2.4 |
I had to fix your permissions (the bot requires direct account addition, not group membership). Please try again. |
/cherry-pick v2.4 |
…vingsRecommendationsAllowLists (#3645) * [ENG-2729] Add resource reference files for kubecostProductConfigs.savingsRecommendationsAllowLists
@biancaburtoiu amazing work! |
…vingsRecommendationsAllowLists (#3645) (#3650) * [ENG-2729] Add resource reference files for kubecostProductConfigs.savingsRecommendationsAllowLists Co-authored-by: Bianca Burtoiu <[email protected]>
What does this PR change?
This PR adds 3 resource files:
cost-analyzer/savings-recommendations-allow-lists-aws.yaml
cost-analyzer/savings-recommendations-allow-lists-gcp.yaml
cost-analyzer/savings-recommendations-allow-lists-azure.yaml
These files contain the complete lists of supported instance types for the custom allow lists feature in Savings Recommendations - see https://kubecost.atlassian.net/browse/ENG-2653
The lists are in YAML format for users to be able to easily copy paste their desired items into their
values.yaml
file at:The URLs for these files will be shared as reference in the public API docs for this page, under this PR: kubecost/docs#1123
Does this PR rely on any other PRs?
Public docs PR: kubecost/docs#1123
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Users can refer to a set of resource files for every supported CSP (AWS, GCP, Azure) for the complete lists of supported instance types for custom allow lists in Savings Recommendations.
Links to Issues or tickets this PR addresses or fixes
https://kubecost.atlassian.net/browse/ENG-2729
What risks are associated with merging this PR? What is required to fully test this PR?
N/A
How was this PR tested?
N/A
Have you made an update to documentation? If so, please provide the corresponding PR.
See public docs PR mentioned above: kubecost/docs#1123