Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-2729] Add resource reference files for kubecostProductConfigs.savingsRecommendationsAllowLists #3645

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

biancaburtoiu
Copy link
Collaborator

@biancaburtoiu biancaburtoiu commented Sep 6, 2024

What does this PR change?

This PR adds 3 resource files:

  • cost-analyzer/savings-recommendations-allow-lists-aws.yaml
  • cost-analyzer/savings-recommendations-allow-lists-gcp.yaml
  • cost-analyzer/savings-recommendations-allow-lists-azure.yaml

These files contain the complete lists of supported instance types for the custom allow lists feature in Savings Recommendations - see https://kubecost.atlassian.net/browse/ENG-2653

The lists are in YAML format for users to be able to easily copy paste their desired items into their values.yaml file at:

kubecostProductConfigs:
    savingsRecommendationsAllowLists:
        AWS: 
            - t2.small
            - ...
        GCP:
            - ...
         Azure:
            - ...

The URLs for these files will be shared as reference in the public API docs for this page, under this PR: kubecost/docs#1123

Does this PR rely on any other PRs?

Public docs PR: kubecost/docs#1123

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Users can refer to a set of resource files for every supported CSP (AWS, GCP, Azure) for the complete lists of supported instance types for custom allow lists in Savings Recommendations.

Links to Issues or tickets this PR addresses or fixes

https://kubecost.atlassian.net/browse/ENG-2729

What risks are associated with merging this PR? What is required to fully test this PR?

N/A

How was this PR tested?

N/A

Have you made an update to documentation? If so, please provide the corresponding PR.

See public docs PR mentioned above: kubecost/docs#1123

@srpomeroy
Copy link
Contributor

@biancaburtoiu I think it would be best to include the relevant helm keys in these files so that these files could be cloned, modified, and used as a values file.

@biancaburtoiu
Copy link
Collaborator Author

@biancaburtoiu I think it would be best to include the relevant helm keys in these files so that these files could be cloned, modified, and used as a values file.

@srpomeroy I've modified each of the 3 files to include the corresponding keys - just double checking that's what you expected?

Copy link
Contributor

@srpomeroy srpomeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @biancaburtoiu

cc: @jessegoodier in case you care about folder structure or anything else.

@biancaburtoiu biancaburtoiu merged commit e98d38e into develop Sep 10, 2024
19 checks passed
@biancaburtoiu biancaburtoiu deleted the biancaburtoiu/eng-2729 branch September 10, 2024 12:21
biancaburtoiu added a commit that referenced this pull request Sep 10, 2024
…vingsRecommendationsAllowLists (#3645)

* [ENG-2729] Add resource reference files for kubecostProductConfigs.savingsRecommendationsAllowLists
@biancaburtoiu
Copy link
Collaborator Author

/cherry-pick v2.4

@chipzoller
Copy link
Collaborator

I had to fix your permissions (the bot requires direct account addition, not group membership). Please try again.

@biancaburtoiu
Copy link
Collaborator Author

/cherry-pick v2.4

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 10, 2024
…vingsRecommendationsAllowLists (#3645)

* [ENG-2729] Add resource reference files for kubecostProductConfigs.savingsRecommendationsAllowLists
@jessegoodier
Copy link
Collaborator

@biancaburtoiu amazing work!
@srpomeroy I figured that these are similar in function to the other value files in that folder. We discussed on slack.

biancaburtoiu added a commit that referenced this pull request Sep 10, 2024
…vingsRecommendationsAllowLists (#3645) (#3650)

* [ENG-2729] Add resource reference files for kubecostProductConfigs.savingsRecommendationsAllowLists

Co-authored-by: Bianca Burtoiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants