-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mutation webhook #655
mutation webhook #655
Conversation
// TODO: reset all versions to v1 before releasing. |
Codecov Report
@@ Coverage Diff @@
## main #655 +/- ##
==========================================
- Coverage 35.93% 35.02% -0.92%
==========================================
Files 25 25
Lines 9018 8888 -130
==========================================
- Hits 3241 3113 -128
- Misses 5327 5331 +4
+ Partials 450 444 -6
Continue to review full report at Codecov.
|
595de4b
to
176e6bf
Compare
Here is my first feedback.
Besides, I'll give you some feedback for KubeArmorAdmission soon. |
1 similar comment
Here is my first feedback.
Besides, I'll give you some feedback for KubeArmorAdmission soon. |
pkg/KubeArmorAnnotation/config/certmanager/kustomizeconfig.yaml
Outdated
Show resolved
Hide resolved
e3e8294
to
c8d9326
Compare
c8d9326
to
b762ba6
Compare
@achrefbensaad can you (1) rebase the code, (2) exclude the updates for CI and kubeUpdate.go, and (3) make it a single commit? |
ef9a5bf
to
7873221
Compare
Hey @nam-jaehyun, I rebased(1) and squashed (3) the commits on top of main. |
7873221
to
c4623e6
Compare
Signed-off-by: Achref Ben Saadd <[email protected]>
c4623e6
to
ce04875
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge it
Work related to this issue