fixed review notes

Signed-off-by: Achref Ben Saadd <[email protected]>

pkg/KubeArmorAnnotation/.gitignore

@@ -1,4 +1,3 @@
-
 # Binaries for programs and plugins
 *.exe
 *.exe~

pkg/KubeArmorAnnotation/Dockerfile

@@ -26,4 +26,4 @@ FROM gcr.io/distroless/static
 WORKDIR /
 COPY --from=builder /workspace/manager .
 
-ENTRYPOINT ["/manager"]
+ENTRYPOINT ["/manager"]

pkg/KubeArmorAnnotation/Makefile

@@ -2,7 +2,7 @@
 # Copyright 2021 Authors of KubeArmor
 
 # Image URL to use all building/pushing image targets
-IMG ?= controller:latest
+IMG ?= kubearmor/kubearmor-annotation-manager:latest
 # Produce CRDs that work back to Kubernetes 1.11 (no version conversion)
 CRD_OPTIONS ?= "crd:trivialVersions=true,preserveUnknownFields=false"
 
@@ -86,7 +86,6 @@ deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in
 undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/config.
 	$(KUSTOMIZE) build config/default | kubectl delete -f -
 
-
 CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
 controller-gen: ## Download controller-gen locally if necessary.
 	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/[email protected])

pkg/KubeArmorAnnotation/config/certmanager/certificate.yaml

@@ -18,4 +18,4 @@ spec:
   issuerRef:
     kind: Issuer
     name: selfsigned-issuer
-  secretName: webhook-server-cert
+  secretName: webhook-server-cert

pkg/KubeArmorAnnotation/config/certmanager/kustomization.yaml

@@ -5,4 +5,4 @@ resources:
 - certificate.yaml
 
 configurations:
-- kustomizeconfig.yaml
+- kustomizeconfig.yaml

pkg/KubeArmorAnnotation/config/certmanager/kustomizeconfig.yaml

@@ -12,4 +12,4 @@ varReference:
   path: spec/commonName
 - kind: Certificate
   group: cert-manager.io
-  path: spec/dnsNames
+  path: spec/dnsNames

pkg/KubeArmorAnnotation/config/webhook/kustomization.yaml

@@ -3,4 +3,4 @@ resources:
 - service.yaml
 
 configurations:
-- kustomizeconfig.yaml
+- kustomizeconfig.yaml

pkg/KubeArmorAnnotation/config/webhook/kustomizeconfig.yaml

@@ -13,4 +13,4 @@ namespace:
   create: true
 
 varReference:
-- path: metadata/annotations
+- path: metadata/annotations

pkg/KubeArmorAnnotation/config/webhook/service.yaml

@@ -9,4 +9,4 @@ spec:
       protocol: TCP
       targetPort: 9443
   selector:
-    control-plane: controller-manager
+    control-plane: controller-manager

pkg/KubeArmorAnnotation/hack/boilerplate.go.txt

@@ -1,15 +1,2 @@
-/*
-Copyright 2022.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
+// SPDX-License-Identifier: Apache-2.0
+// Copyright 2021 Authors of KubeArmor

pkg/KubeArmorAnnotation/main.go

@@ -1,22 +1,6 @@
 // SPDX-License-Identifier: Apache-2.0
 // Copyright 2021 Authors of KubeArmor
 
-/*
-Copyright 2022.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
 package main
 
 import (