Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deployment):update rbac rules for jobs/cronjobs for kubearmor clusterRole #1762

Merged
merged 1 commit into from
May 24, 2024

Conversation

Prateeknandle
Copy link
Collaborator

@Prateeknandle Prateeknandle commented May 22, 2024

Purpose of PR?:
To get owner info for job/cronjobs, we require get rule, which does not exist currently.

Connected to #1748

Fixes #

Does this PR introduce a breaking change?
no

If the changes in this PR are manually verified, list down the scenarios covered::
yes

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@Prateeknandle Prateeknandle changed the title update rbac rules for jobs/cronjobs for kubearmor clusterRole chore(deployment):update rbac rules for jobs/cronjobs for kubearmor clusterRole May 22, 2024
@Prateeknandle Prateeknandle marked this pull request as ready for review May 23, 2024 14:53
@rksharma95 rksharma95 merged commit 0eaec66 into kubearmor:main May 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants