Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core) : updating owner info for job/cronjob controller #1748

Merged
merged 1 commit into from
May 9, 2024

Conversation

Prateeknandle
Copy link
Collaborator

@Prateeknandle Prateeknandle commented May 7, 2024

Purpose of PR?:
onwer info was showing controller type Pod if owner was job.

Partially Fixes # https://accu-knox.atlassian.net/browse/CNAPP-10787

Does this PR introduce a breaking change?
no

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #<issue number>
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: Prateek Nandle <[email protected]>
@Prateeknandle Prateeknandle changed the title fix(core) : owner info fixes fix(core) : updating owner info for job/cronjob controller May 7, 2024
Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants