Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execname support #1664

Merged
merged 10 commits into from
Mar 7, 2024

Conversation

daemon1024
Copy link
Member

@daemon1024 daemon1024 commented Mar 6, 2024

Purpose of PR?:

Based on discussion at https://kubearmor.slack.com/archives/C01F9V3SEHY/p1709480346589829

Does this PR introduce a breaking change?
NA

If the changes in this PR are manually verified, list down the scenarios covered::
Added testcase

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@daemon1024 daemon1024 force-pushed the add-execname-support branch 3 times, most recently from 429a21b to 675cdec Compare March 7, 2024 07:56
…tching

This will help us to create and enforce policies with
- path: apt
instead of
- path: /usr/bin/apt
- path: /bin/apt
and the likes

Signed-off-by: daemon1024 <[email protected]>
@daemon1024 daemon1024 force-pushed the add-execname-support branch from 675cdec to 719f1a9 Compare March 7, 2024 11:19
@daemon1024 daemon1024 requested a review from rksharma95 March 7, 2024 12:28
rksharma95
rksharma95 previously approved these changes Mar 7, 2024
nyrahul
nyrahul previously approved these changes Mar 7, 2024
Copy link
Contributor

@nyrahul nyrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few minor comments.

KubeArmor/core/unorchestratedUpdates.go Show resolved Hide resolved
KubeArmor/BPF/enforcer.bpf.c Show resolved Hide resolved
@daemon1024 daemon1024 dismissed stale reviews from nyrahul and rksharma95 via 9e7f790 March 7, 2024 16:12
@daemon1024 daemon1024 requested review from rksharma95 and nyrahul March 7, 2024 16:13
docker events seem to be causing flakey behavior. docker under the hood does use containerd runtime. this commit checks if containerd socket is availble in docker runtime and uses it.

Signed-off-by: daemon1024 <[email protected]>
Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PrimalPimmy
PrimalPimmy previously approved these changes Mar 7, 2024
no idea why it's so flakey after k3s update

Signed-off-by: daemon1024 <[email protected]>
@DelusionalOptimist DelusionalOptimist merged commit 68bc93b into kubearmor:main Mar 7, 2024
19 checks passed
@DelusionalOptimist DelusionalOptimist mentioned this pull request Mar 19, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants