-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execname support #1664
Merged
DelusionalOptimist
merged 10 commits into
kubearmor:main
from
daemon1024:add-execname-support
Mar 7, 2024
Merged
Add execname support #1664
DelusionalOptimist
merged 10 commits into
kubearmor:main
from
daemon1024:add-execname-support
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon1024
requested review from
nyrahul,
Aryan-sharma11,
DelusionalOptimist and
Prateeknandle
March 6, 2024 19:35
daemon1024
commented
Mar 6, 2024
daemon1024
force-pushed
the
add-execname-support
branch
3 times, most recently
from
March 7, 2024 07:56
429a21b
to
675cdec
Compare
…tching This will help us to create and enforce policies with - path: apt instead of - path: /usr/bin/apt - path: /bin/apt and the likes Signed-off-by: daemon1024 <[email protected]>
Signed-off-by: daemon1024 <[email protected]>
…cy matching on alerts Signed-off-by: daemon1024 <[email protected]>
Signed-off-by: daemon1024 <[email protected]>
…event Signed-off-by: daemon1024 <[email protected]>
daemon1024
force-pushed
the
add-execname-support
branch
from
March 7, 2024 11:19
675cdec
to
719f1a9
Compare
rksharma95
previously approved these changes
Mar 7, 2024
nyrahul
previously approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Few minor comments.
Signed-off-by: daemon1024 <[email protected]>
Signed-off-by: daemon1024 <[email protected]>
docker events seem to be causing flakey behavior. docker under the hood does use containerd runtime. this commit checks if containerd socket is availble in docker runtime and uses it. Signed-off-by: daemon1024 <[email protected]>
DelusionalOptimist
previously approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Rudraksh Pareek <[email protected]>
DelusionalOptimist
previously approved these changes
Mar 7, 2024
PrimalPimmy
previously approved these changes
Mar 7, 2024
no idea why it's so flakey after k3s update Signed-off-by: daemon1024 <[email protected]>
daemon1024
dismissed stale reviews from PrimalPimmy and DelusionalOptimist
via
March 7, 2024 20:31
c0761bf
DelusionalOptimist
approved these changes
Mar 7, 2024
PrimalPimmy
approved these changes
Mar 7, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Based on discussion at https://kubearmor.slack.com/archives/C01F9V3SEHY/p1709480346589829
Does this PR introduce a breaking change?
NA
If the changes in this PR are manually verified, list down the scenarios covered::
Added testcase
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>