-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import kube-rt tree #258
Import kube-rt tree #258
Conversation
Means that all events can now take advantage of Scheduler's debouncing, at the cost of some latency when reacting to new events. Fixes #2.
this allows reconcilers to not live within a giant lambda and instead have Arc'd data (like in actix). It does mean we have to have one extra parameter in controller, but that's likely to get revamped a bit with a Manager.
does not compile yet
also does not work yet due to different opaque types :(
but with restrictions on the error types..
kube-rt2 controller select_all + ControllerBuilder
The last of my core-goals from last week's comment are actually achieved now. Probably going to merge this on the weekend. Not sure whether to smash all the crates together into one super-crate or, I know that was the plan, but starting to think that maybe there's a benefit to having the boundaries outside the crate level for #204 . Plus, it also lets us have one kube release that's a proper migration release where people can switch over. Regardless, will start porting over most of the examples later. |
👍 from me on separate crates. |
A WIP import that aims to get to point 1 of #148 (comment)
Marking down some key points:
git subtree add -P kube-runtime [email protected]:teozkr/kube-rt.git master
- [ ] migrate from kube-runtime to kube/src/runtime or kube/src/runtime2- deprecate old runtime firstThe latter migration requires consolidating the normal dependencies and dealing with some unpublishable things:
deal with #[project] deprecated attr warning RT2: fix pin project deprecation #259
[ ] unify error handling (move to snafu + inside kube + color_eyre inside examples)can be done if the crates are properly unitedmigrate examples from old runtime to new runtime (might save some of these for later so we can do a migration release)
Maybe try to also get examples as a top level directory. Tried that before, but it was slightly annoying with workspaces