Controller<T> #184
Closed
Controller<T> #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
force-pushed
the
controller-start
branch
2 times, most recently
from
51239fd to
cea8d9a
Compare
nightkr
reviewed
Mar 16, 2020
| // Prepare a sender so we can stack things back on the channel | ||
| let txa = tx.clone(); | ||
| // Event loop that triggers the reconcile fn | ||
| tokio::spawn(async move { |
There was a problem hiding this comment.
Makes sense while prototyping.. but we should try to avoid tokio::spawn before releasing, because it means that kube-rs has to take complete control of the error handling. Should be possible to replace most uses with some variant of try_join_all/try_join!.
nightkr
reviewed
Mar 16, 2020
| impl<K: 'static, F: 'static> Controller<K, F> | ||
| where | ||
| K: Clone + DeserializeOwned + Meta + Send + Sync, | ||
| F: Fn(ReconcileEvent) -> Result<ReconcileStatus> + Send + Sync, |
There was a problem hiding this comment.
It is pretty limiting that F can't return an impl Future.
think it's probably easier to do callbacks..
|
Replaced by #258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketch of Controller. Heavy WIP for #148
Some thoughts: