Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import kube-rt #257

Closed
wants to merge 2 commits into from
Closed

Import kube-rt #257

wants to merge 2 commits into from

Conversation

clux
Copy link
Member

@clux clux commented Jun 22, 2020

A WIP import that aims to get to point 1 of #148 (comment)

Marking down some key points:

  • imported kube-rt codebase (impersonated Theo for initial dump, since he wrote all of it)
  • made it work as part of workspace with joint examples dir
  • consolidate dev-deps
  • migrate from kube-runtime to kube/src/runtime or kube/src/runtime2

The latter migration requires consolidating the normal dependencies and dealing with some unpublishable things:

  • deal with pin-cell git dependency - cannot just use 0.1.1 due to:
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/clux/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/pin-cell-0.1.1/src/lib.rs:3:1
  |
3 | #![feature(pin, arbitrary_self_types)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  • deal with #[project] deprecated attr warning
warning: use of deprecated item 'project': consider naming projected type by passing `project` argument to #[pin_project] attribute instead, see release note <https://github.com/taiki-e/pin-project/releases/tag/v0.4.21> for details
  --> kube-runtime/src/scheduler.rs:59:3
   |
59 | #[project]
   |   ^^^^^^^
  • unify error handling (move to snafu + inside kube + color_eyre inside examples)
  • migrate examples from old runtime to new runtime
    Maybe try to also get examples as a top level directory. Tried that before, but it was slightly annoying with workspaces

nightkr and others added 2 commits June 22, 2020 11:02
place kube-runtime into the workspace, consolidate dev-deps and handle
ConfigMap 1.18 defaults.
@clux
Copy link
Member Author

clux commented Jun 22, 2020

Replaced by #258

@clux clux closed this Jun 22, 2020
@clux clux deleted the kube-rt branch June 22, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants