-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTOR-7845 Fix for threading issue in flushAndClose for reader job channels #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the target branch to 3.1.0
906c159
to
18aeee9
Compare
e5l
approved these changes
Nov 25, 2024
18aeee9
to
06be3d9
Compare
* Use stdlib `use` extension-function * Update type checks
06be3d9
to
3e3d808
Compare
3e3d808
to
b0fcd93
Compare
e5l
pushed a commit
that referenced
this pull request
Nov 28, 2024
e5l
pushed a commit
that referenced
this pull request
Nov 29, 2024
e5l
pushed a commit
that referenced
this pull request
Dec 3, 2024
e5l
pushed a commit
that referenced
this pull request
Dec 3, 2024
osipxd
pushed a commit
that referenced
this pull request
Dec 6, 2024
bjhham
added a commit
that referenced
this pull request
Dec 9, 2024
bjhham
added a commit
that referenced
this pull request
Dec 11, 2024
bjhham
added a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Core, I/O
Motivation
KTOR-7845 File is not commited after closing writeChannel() of the file
Solution
The problem here is that
flushAndClose()
doesn't wait for theReaderJob
to finish so it has no effect on the final destination of the data. By adding a hook to wait for the job to complete, we can daisy chain these jobs with some trust thatflushAndClose()
will work properly from the perspective of the caller.For reference, here is the
writeChannel
utility function: