KTOR-7606 Make Closable implement AutoCloseable #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
force-pushed
the
osipxd/stdlib-closable
branch
from
f9f9f46
to
e004ca2
Compare
osipxd
commented
Oct 18, 2024
| } | ||
| } | ||
| } | ||
| public expect interface Closeable : AutoCloseable |
There was a problem hiding this comment.
We could deprecate our Closable interface and remove it in a major update if it is unnecessary.
osipxd
force-pushed
the
osipxd/stdlib-closable
branch
from
e004ca2
to
45043db
Compare
e5l
approved these changes
Oct 22, 2024
osipxd
added a commit
that referenced
this pull request
Oct 30, 2024
* Use stdlib `use` extension-function * Update type checks
osipxd
added a commit
that referenced
this pull request
Oct 31, 2024
* Use stdlib `use` extension-function * Update type checks
osipxd
added a commit
that referenced
this pull request
Nov 8, 2024
* Use stdlib `use` extension-function * Update type checks
e5l
pushed a commit
that referenced
this pull request
Nov 13, 2024
* Use stdlib `use` extension-function * Update type checks
e5l
pushed a commit
that referenced
this pull request
Nov 14, 2024
* Use stdlib `use` extension-function * Update type checks
osipxd
added a commit
that referenced
this pull request
Nov 16, 2024
* Use stdlib `use` extension-function * Update type checks
e5l
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Use stdlib `use` extension-function * Update type checks
osipxd
added a commit
that referenced
this pull request
Nov 22, 2024
* Use stdlib `use` extension-function * Update type checks
e5l
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Use stdlib `use` extension-function * Update type checks
e5l
pushed a commit
that referenced
this pull request
Nov 26, 2024
* Use stdlib `use` extension-function * Update type checks
e5l
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Use stdlib `use` extension-function * Update type checks
bjhham
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Use stdlib `use` extension-function * Update type checks
e5l
pushed a commit
that referenced
this pull request
Nov 28, 2024
* Use stdlib `use` extension-function * Update type checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Core,
ktor-uiMotivation
Improve UX - make it possible to call
AutoCloseableextensions on ourCloseabletypeKTOR-7606 Migrate to kotlin.AutoCloseable
Solution
Make
ClosableimplementAutoCloseable. Usekotlin.useextension function instead of our implementation.It's better to review commit-by-commit.