Fix EuiTitle line-height in Amsterdam (elastic#4079)

kshitij86 · Nov 29, 2020 · 7a801bd · 7a801bd
1 parent 900b76d
commit 7a801bd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,8 @@
 ## [`master`](https://github.com/elastic/eui/tree/master)
 
-No public interface changes since `29.2.0`.
+**Theme: Amsterdam**
+
+- Fixed `line-height` on `EuiTitle` ([#4079](https://github.com/elastic/eui/pull/4079))
 
 ## [`29.2.0`](https://github.com/elastic/eui/tree/v29.2.0)
 

diff --git a/src/themes/eui-amsterdam/global_styling/variables/_typography.scss b/src/themes/eui-amsterdam/global_styling/variables/_typography.scss
@@ -14,6 +14,11 @@ $euiFontSizeL:     ceil($euiFontSize * 1.57); // 22px // h3
 $euiFontSizeXL:   floor($euiFontSize * 1.93); // 27px // h2
 $euiFontSizeXXL:  floor($euiFontSize * 2.43); // 34px // h1
 
+// Use 8px increments for base gridline
+@function lineHeightFromBaseline($multiplier: 3) {
+  @return convertToRem(($euiSize/2)*$multiplier);
+}
+
 $euiTitles: (
   'xxxs': (
     'font-size': $euiFontSizeXS,