Fix EuiTitle lineheight #4079
Merged
Fix EuiTitle lineheight #4079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4079/ |
cchaos
approved these changes
Sep 28, 2020
src/themes/eui-amsterdam/global_styling/variables/_typography.scss
Outdated
Show resolved
Hide resolved
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4079/ |
cchaos
force-pushed
the
amst/fix-title-lineheight
branch
from
c292195 to
72818ab
Compare
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4079/ |
|
Ugh, flakey flakey, |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4079/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an unintended (i think?) consequence of reducing
$euiFontSizeto14pxwhich causedEuiTitleto use line-heights that increment in units of7px(42, 35, 28, 21). I think we should keepEuiTitleline-heights as they are in the base theme so that they increment in units of8px(48, 40, 32, 24).Digging in
Since our
lineHeightFromBaselinefunction references$euiFontSizeand divides it by 2, changing the font size variable caused our baseline to increment in units of7px(14 / 2 = 7) forEuiTitle.EuiTitleis the only component that uses thelineHeightFromBaselinefunction. Because EuiTitle is used in so many places, this7pxincrement throws a lot of components off of our imaginary grid. This can cause elements to align in weird ways, for example:It also feels strange that the medium scale for
EuiTexth1uses a 48px line height, whereas the large size forEuiTitleuses a 42px line height:See screenshot
What do you think?
Checklist
Checked in Chrome, Safari, Edge, and FirefoxProps have proper autodocsAdded documentationChecked Code Sandbox works for the any docs examplesAdded or updated jest testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes