Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Refactor transport mode badge and icon styles #558

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 21, 2025

TL;DR

Updated the visual styling of transport mode indicators to improve consistency and readability

What changed?

  • Increased transport mode icon size from 18sp to 22sp
  • Adjusted badge height to match new icon size
  • Simplified typography by removing redundant font weight modifications
  • Standardized on labelLarge typography style
  • Reordered border and background modifiers for consistent rendering

Why make this change?

To establish visual consistency across transport mode indicators while improving readability through larger text size and cleaner typography implementation. This change aligns with design system best practices by reducing redundant style modifications.

Copy link
Owner Author

ksharma-xyz commented Jan 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title Update size of TransportMode Info to 22sp and also change text style to labelLarge, which is Bold UI: Refactor transport mode badge and icon styles Jan 24, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 24, 2025 07:57
@ksharma-xyz ksharma-xyz changed the base branch from 01-21-update_theme_background_colors to graphite-base/558 January 24, 2025 08:05
@ksharma-xyz ksharma-xyz force-pushed the 01-21-update_size_of_transportmode_info_to_22sp_and_also_change_text_style_to_labellarge_which_is_bold branch from 9ddb6dc to e6257c4 Compare January 24, 2025 08:15
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/558 to main January 24, 2025 08:16
@ksharma-xyz ksharma-xyz force-pushed the 01-21-update_size_of_transportmode_info_to_22sp_and_also_change_text_style_to_labellarge_which_is_bold branch from e6257c4 to 0f400c9 Compare January 24, 2025 08:16
@ksharma-xyz ksharma-xyz added this to the 1.0.6 milestone Jan 24, 2025
@ksharma-xyz ksharma-xyz merged commit 9d31061 into main Jan 24, 2025
2 checks passed
Copy link
Owner Author

Merge activity

  • Jan 24, 3:28 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 01-21-update_size_of_transportmode_info_to_22sp_and_also_change_text_style_to_labellarge_which_is_bold branch January 24, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant