Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update light and dark surface colors #557

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 21, 2025

TL;DR

Updated surface colors for both light and dark themes

What changed?

  • Light theme surface color changed from 0xFFFFFBFF to 0xFFFFFFFF (slightly whiter)
  • Dark theme surface color changed from 0xFF1F1B16 to 0xFF1C1B1A (slightly darker)

How to test?

  1. Launch the app in both light and dark modes
  2. Navigate through different screens
  3. Verify the background surface colors appear correct
  4. Ensure there's proper contrast between surface and content

Why make this change?

The surface color adjustments improve visual consistency and maintain better contrast ratios with other theme colors. The light theme now uses pure white for a cleaner look, while the dark theme's adjustment provides better visual comfort in low-light conditions.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title Update theme background colors UI: Update light and dark surface colors Jan 24, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 24, 2025 07:56
Copy link
Owner Author

ksharma-xyz commented Jan 24, 2025

Merge activity

  • Jan 24, 3:06 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 24, 3:15 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz merged commit 72a64d6 into main Jan 24, 2025
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 01-21-update_theme_background_colors branch January 24, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant