Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Enhance splash screen animation and theming #328

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 9, 2024

TL;DR

Enhanced the splash screen with dynamic theming and improved state management

Removed usage of Duration, as it was taking extra 50ms to convert from Duration in milliseconds to int

What changed?

  • Added dynamic logo and background color support to the splash screen
  • Migrated splash screen state management to use StateFlow
  • Introduced loading state handling in SplashViewModel
  • Simplified animation logic with proper state management
  • Removed system theme dependency for logo coloring
  • Streamlined parameter passing for theme colors

Copy link
Owner Author

ksharma-xyz commented Nov 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

@ksharma-xyz ksharma-xyz changed the title SplashScreen - janky frame UI: Enhance splash screen animation and theming Nov 9, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 9, 2024 08:18
@ksharma-xyz ksharma-xyz changed the base branch from 11-09-update_font_size to graphite-base/328 November 9, 2024 08:23
@ksharma-xyz ksharma-xyz force-pushed the 11-09-splashscreen_-_janky_frame branch from 517ce67 to abdd82d Compare November 9, 2024 08:24
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/328 to main November 9, 2024 08:24
@ksharma-xyz ksharma-xyz force-pushed the 11-09-splashscreen_-_janky_frame branch from abdd82d to d1cedd7 Compare November 9, 2024 08:24
@ksharma-xyz ksharma-xyz merged commit e21f687 into main Nov 9, 2024
3 checks passed
Copy link
Owner Author

Merge activity

  • Nov 9, 3:32 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 11-09-splashscreen_-_janky_frame branch November 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant