-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge release/v1.0.3-base
to main
#237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new flag `engine-sync` and `sync.Config` struct for engine p2p sync - Modify `EngineQueue` to support engine p2p sync - Add e2e test cases - Modify related components to pass sync config - Modify execution engine specs - Fix reorg depth check, Add `skip-sync-start-check` flag See Optimism PR#6243.
feat(node): implement engine P2P sync mode
chore: add config file for semantic-prs
- Proposer to Sequencer. - ProposerRewardVault to L1FeeVault.
…-to-sequencer refac!: renaming about proposer
Since we have dynamic gas usage in unbond and priority validator selection logic, it is hard to estimate exact gas usage. This leads to frequent transaction failures, so to avoid this, set the output submission gas limit `1.5 * estimated gas`.
- Update l2OutputOracleSubmissionInterval to 10 min.
…sion-interval-sepolia chore: update output submission interval in sepolia
feat(validator): add gas limit margin when submitting output
feat: withdraw validator rewards directly to l2
* feat(contracts): remove minWithdrawalAmount of FeeVault * feat(contracts): add withdraw to L2 in FeeVault
chore(contracts): make `_processWithdrawal()` be virtual for overriding
In the previous code, anyone can call `withdraw` or `withdrawToL2` and the reward is sent to the caller. This need to be fixed so that the reward is sent to the recipient. And I added a modifier that only the recipient can call. In case of `withdraw`, it requires additional action on L1 (prove and finalize), so this should be controlled only by the recipient.
fix(contracts): change so that only recipient can withdraw from vault
…1.0.3 chore: update deployments for v1.0.3
Could you change the title of PR to pass semantic PR check? |
release/v1.0.3-base
to main
release/v1.0.3-base
to main
seolaoh
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pangssu
approved these changes
Dec 14, 2023
kangsorang
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge base branch of
v1.0.3
tomain
.