Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge release/v1.0.3-base to main #237

Merged
merged 23 commits into from
Dec 15, 2023
Merged

feat: merge release/v1.0.3-base to main #237

merged 23 commits into from
Dec 15, 2023

Conversation

0xHansLee
Copy link
Contributor

Merge base branch of v1.0.3 to main.

jyc228 and others added 23 commits October 12, 2023 16:49
- Add new flag `engine-sync` and `sync.Config` struct for engine p2p sync
- Modify `EngineQueue` to support engine p2p sync
- Add e2e test cases
- Modify related components to pass sync config
- Modify execution engine specs
- Fix reorg depth check, Add `skip-sync-start-check` flag

See Optimism PR#6243.
feat(node): implement engine P2P sync mode
- Proposer to Sequencer.
- ProposerRewardVault to L1FeeVault.
…-to-sequencer

refac!: renaming about proposer
Since we have dynamic gas usage in unbond and priority validator selection
logic, it is hard to estimate exact gas usage. This leads to frequent
transaction failures, so to avoid this, set the output submission gas limit
`1.5 * estimated gas`.
- Update l2OutputOracleSubmissionInterval to 10 min.
…sion-interval-sepolia

chore: update output submission interval in sepolia
feat(validator): add gas limit margin when submitting output
feat: withdraw validator rewards directly to l2
* feat(contracts): remove minWithdrawalAmount of FeeVault

* feat(contracts): add withdraw to L2 in FeeVault
chore(contracts): make `_processWithdrawal()` be virtual for overriding
In the previous code, anyone can call `withdraw` or `withdrawToL2`
and the reward is sent to the caller. This need to be fixed so that
the reward is sent to the recipient.
And I added a modifier that only the recipient can call.
In case of `withdraw`, it requires additional action on L1 (prove and finalize),
 so this should be controlled only by the recipient.
fix(contracts): change so that only recipient can withdraw from vault
…1.0.3

chore: update deployments for v1.0.3
@0xHansLee 0xHansLee requested a review from a team December 14, 2023 06:14
@0xHansLee 0xHansLee requested a review from a team as a code owner December 14, 2023 06:14
@seolaoh
Copy link
Contributor

seolaoh commented Dec 14, 2023

Could you change the title of PR to pass semantic PR check?

@0xHansLee 0xHansLee changed the title merge release/v1.0.3-base to main feat: merge release/v1.0.3-base to main Dec 14, 2023
Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kangsorang kangsorang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xHansLee 0xHansLee merged commit 5fb28e1 into main Dec 15, 2023
1 check passed
@0xHansLee 0xHansLee deleted the release/v1.0.3-base branch December 15, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants