fix(contracts): change so that only recipient can withdraw from vault #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous code, anyone can call `withdraw` or `withdrawToL2` and the reward is sent to the caller. This need to be fixed so that the reward is sent to the recipient. And I added a modifier that only the recipient can call. In case of `withdraw`, it requires additional action on L1 (prove and finalize), so this should be controlled only by the recipient.
Pangssu
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous code, anyone can call
withdraworwithdrawToL2and the reward is sent to the caller.This need to be fixed so that the reward is sent to the recipient.
And I added a modifier that only the recipient can call.
In case of
withdraw, it requires additional action on L1 (prove and finalize), so this should be controlled only by the recipient.