-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev -> main #212
Merged
Merged
dev -> main #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add mainnet deployments and update some config
chore: rename package organization
docs: add mainnet to `README.md`
docs: apply markdownlint
Migrate all v1 code in the urfave-cli to v2. Calibrate some defaults.
chore: upgrade urfave-cli v1 to v2
…1.0.0 chore: update sepolia deployments to v1.0.0
docs: add security audit by ChainLight
…ents chore: update kroma deployments
…ission (#206) Current, the next priority validator is selected when unbond based on the last finalized output. However, if the output of `nextUnbondOutputIndex` is submitted in public round, no output will be unbonded while `tryUnbond()`, leading to the same validator to be kept. To select the next validator for every submission randomly, the next priority validator is selected when output submission.
…ed-permissions
feat(contracts): add L2 governance contracts
When the contract is upgraded, the value of the contract used by each component should be updated. Therefore, when a contract upgrade event occurs, it reads back the value of that contract and changes the config.
chore: change timelock delay
Remove protocol for using custom time-lock zero delay for urgent situations. The default Timelock delay has also been changed to 7 days.
Modify next validator selection to be after decrease balance. This prevents accounts with insufficient balance from being selected as the next validator.
…-selection feat(contracts): modify the next validator selection logic
The following tags are reflected below. (https://github.com/kroma-network/kroma/releases/tag/v1.0.1-rc.3)
seolaoh
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kangsorang
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I converted this PR to draft since some changes also need to be included for |
…eshold feat(contracts): remove validator reward claim threshold
chore: update ValidatorRewardVault deployment on sepolia
Deploy config added - l2GovernorVotingPeriodBlocks. Seperate transfetOwnership action to hardhat task. Rollback mainnet config timeLockMinDelaySeconds. This value will be managed separately.
…-governance chore: add deploy config for l2 protocol governance
…-deployments chore: update kromaSepolia(L2) deployments
Pangssu
approved these changes
Oct 19, 2023
seolaoh
approved these changes
Oct 19, 2023
kangsorang
approved these changes
Oct 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is merge PR for
v1.0.1
.