Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): change to select the next validator #206

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

0xHansLee
Copy link
Contributor

Description

Current, the next priority validator is selected when unbond based on the last finalized output. However, if the output of nextUnbondOutputIndex is submitted in public round, no output will be unbonded while tryUnbond(), leading to the same validator to be kept.

To select the next validator for every submission randomly, the next priority validator is selected when output submission.

@0xHansLee 0xHansLee self-assigned this Sep 26, 2023
@0xHansLee 0xHansLee requested a review from a team as a code owner September 26, 2023 07:22
@0xHansLee 0xHansLee changed the title feat(contracts): change to select the next validator when output subm… feat(contracts): change to select the next validator Sep 26, 2023
Copy link
Contributor

@kangsorang kangsorang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…ission

Current, the next priority validator is selected when unbond based on the last
finalized output. However, if the output of `nextUnbondOutputIndex` is submitted
in public round, no output will be unbonded while `tryUnbond()`,
leading to the same validator to be kept.
To select the next validator for every submission randomly,
the next priority validator is selected when output submission.
@0xHansLee 0xHansLee force-pushed the feat/change-next-validator-selection branch from 3e9f7ba to a1e3c05 Compare September 27, 2023 02:34
@0xHansLee
Copy link
Contributor Author

I updated the version of ValidatorPool contract in a1e3c05

Copy link
Contributor

@seolaoh seolaoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xHansLee 0xHansLee merged commit bc3dfbf into dev Sep 27, 2023
@0xHansLee 0xHansLee deleted the feat/change-next-validator-selection branch September 27, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants