Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config schema form #81

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Add a config schema form #81

merged 2 commits into from
Nov 11, 2021

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Nov 11, 2021

This adds a config.schema.json file to allow the user to visually configure the plugin via the Homebridge or HOOBS UI.

@kpsuperplane
Copy link
Owner

Thank you!

@kpsuperplane kpsuperplane merged commit d1d3b13 into kpsuperplane:master Nov 11, 2021
@bwp91
Copy link
Contributor Author

bwp91 commented Nov 11, 2021

Thanks for pulling this in. If you’re happy with it then a new version of the plugin published to npm would be super 👍🏻

@MoTechnicalities
Copy link
Contributor

I agree with bwp91!

bwp91's work on the EWeLINK plugin is nothing short of fantastic!

Let's get the ball rolling!

@kpsuperplane
Copy link
Owner

Yup, I just need to fix a few bugs from #74 first

@bwp91
Copy link
Contributor Author

bwp91 commented Nov 12, 2021

Yup, I just need to fix a few bugs from #74 first

what’s going on?

@kpsuperplane
Copy link
Owner

#76.

I thought the changes wouldn't be pushed out since I didn't cut a release but apparently not...

@kpsuperplane
Copy link
Owner

I do apologize for taking so long though, been a busy month at work

@bwp91
Copy link
Contributor Author

bwp91 commented Nov 12, 2021

I do apologize for taking so long though, been a busy month at work

Are you on the homebridge discord?

@kpsuperplane
Copy link
Owner

No, I did not realize one existed!

@bwp91
Copy link
Contributor Author

bwp91 commented Nov 12, 2021

No, I did not realize one existed!

https://discord.gg/bHjKNkN

@kpsuperplane
Copy link
Owner

v3.1.0 published to npm!

@MoTechnicalities
Copy link
Contributor

Tested!
It's great!

Thank you.

@BMDan BMDan mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants