-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement dynamic scenes selector #74
feat: implement dynamic scenes selector #74
Conversation
…c funcs The accessory is now passed instead of the single (LightBulb) service so multiple services could be managed in the pilot functions etc.
If I understand it correctly the code inside this if is valid for RGB bulbs as well. Please correct me if I'm wrong.
c79025b
to
797b652
Compare
O.M.G. I'm not home right now so I won't be able to test this till Monday, but this is absolutely phenomenal. Thank you so much for making this happen! |
That should make my wife happy! Don't forget to list circadian rhythm. |
Merging, however will probably not be released for another few days as I decide how to address some lingering issues: I pushed 9bd93e8 to do a couple things:
However two more issues remain:
|
RPReplay_Final1632283167.mov |
Are we able to use Siri to set these dynamic scene "channels?" Does anyone know what the voice commands would be? |
Hey, thanks for merging! Also, I'm testing your changes and they make sense, so far so good. @jeanofthedead |
Sorry to be annoying, but I was wondering if anyone else was having the Scenes selector disappear, or any tips for getting them back? |
Np, it's a bug im still working on |
@jeanofthedead I am having the same issue. This issue appears only when there is multiple lightbulbs registered. In that case, only one lightbulb has the scenes options and the rest disappear. Thanks in advance @kpsuperplane for the fix and for this great plugin. |
WIZ added two new scenes: "Diwali" and "Alarm". May you add them too? |
Hi,
I'm working on a implementation of dynamic scenes selector in Home app. So here is the first somehow usable version 🙂. I have tested it only on RGB bulb type so it would be fine if someone could test it with other types as well. Also I would appreaciate any sort of code review!
As the control for selecting the scene you want is used Television input selector added as service to the parent PlatformAccessory of the device so it get nicely listed under other light's control 🙂. The idea is taken from this article https://sprut.ai/client/article/2760 as well as this implementation in homebridge plugin https://bit.ly/3kju9Lc so thanks them!
Also I would like to say thanks for this project as well!
Solves #65