Warn about images with no registry #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good (besides the conflicts that need to be addressed). I saw a similar behavior in renovate... |
If user specifies a base image with no registry information, things may seem to work as skopeo will use some default value. But it may lead to confusing breakage later if the build system picks a different registry. For example, right now using `fedora` as image spec will make skopeo download `docker.io/library/fedora:40`, but podman uses `registry.fedoraproject.org/fedora:40`. There's no good way to automatically fix it, so let's print a big warning at least. Relates: #67
lubomir
force-pushed
the
warn-about-bare-image
branch
from
b4fabd9 to
2ec7c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user specifies a base image with no registry information, things may seem to work as skopeo will use some default value. But it may lead to confusing breakage later if the build system picks a different registry.
For example, right now using
fedoraas image spec will make skopeo downloaddocker.io/library/fedora:40, but podman usesregistry.fedoraproject.org/fedora:40.There's no good way to automatically fix it, so let's print a big warning at least.