Add variable interpolation to repofile URLs #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubomir
force-pushed
the
repofile-with-vars
branch
2 times, most recently
from
29d1f3f to
cd64e03
Compare
Make it possible to interpolate image labels into the repofile URLs. This can be used to consume the exact same repos that were used to build the base image. Fixes: #26
The repofile can be specified by as a git clone url, commit sha, and path within the repo. All of the values can be substitued with image labels, and the URL can also contain environment variables. Fixes: #26
lubomir
force-pushed
the
repofile-with-vars
branch
from
cd64e03 to
8c7d2ae
Compare
|
I think this will solve the problem described in #26 ;) 👍 |
|
I've just tried it in https://gitlab.com/redhat/rhel/containers/ubi10-init/-/merge_requests/192 and it works as expected. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to interpolate image labels into the repofile URLs. This can be used to consume the exact same repos that were used to build the base image.