Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Go mod & .gitignore #24

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

candiduslynx
Copy link
Contributor

Follow-up to #23

Additionally, you might want to loot at the type conversion from old types to the new ones.
I presume you used the types from Sharepoint, so Int32 instead of Int64 or Float32 instead of Float64 was a deliberate choice, but needed to highlight this code nonetheless.

@candiduslynx
Copy link
Contributor Author

@koltyakov I've looked through the update to v4 you performed & it's a great job! Now the code allows to sync several tables of the same type in parallel, which what I wanted to address in #22.

I have only a small chore to update .gitignore & go.mod files to propose.
Additionally, see the link to the implementation of the type conversions we used in v2.

@koltyakov koltyakov merged commit 4c1b413 into koltyakov:main Oct 31, 2023
@candiduslynx candiduslynx deleted the feat/refactor branch October 31, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants