Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate plugin to github.com/cloudqeury/plugin-sdk/v4 #22

Closed
candiduslynx opened this issue Oct 30, 2023 · 3 comments
Closed

Migrate plugin to github.com/cloudqeury/plugin-sdk/v4 #22

candiduslynx opened this issue Oct 30, 2023 · 3 comments
Assignees
@koltyakov

Comments

@candiduslynx
Copy link
Contributor

No description provided.

@candiduslynx candiduslynx changed the title MIgrate plugin to github.com/cloudqeury/plugin-sdk/v4 Migrate plugin to github.com/cloudqeury/plugin-sdk/v4 Oct 30, 2023
@koltyakov koltyakov self-assigned this Oct 30, 2023
@koltyakov
Copy link
Owner

Migrated to v4.

@candiduslynx
Copy link
Contributor Author

@koltyakov this looks great!

I also started porting the code to plugin-sdk/v4 & have some comments regarding the structure of the plugin.

I'll rebase the code to the latest main & make a PR with suggestions.

@candiduslynx candiduslynx mentioned this issue Oct 31, 2023
Merged
@koltyakov
Copy link
Owner

Thank you @candiduslynx!

Yeah, upgrading the plugin was a bit tricky due to some structural changes and backwards incompatibility with v2. So what I did - scaffolded a blank new plugin and moved business logic also looking to some other plugins.

I'll check the suggestions.

@candiduslynx candiduslynx mentioned this issue Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koltyakov koltyakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@candiduslynx @koltyakov