Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: call console.assert directly in dateToString #226

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

cezarcarvalhaes
Copy link
Contributor

Fixes #225

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #226 (833b15e) into master (b70467e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   99.34%   99.31%   -0.03%     
==========================================
  Files         247      247              
  Lines        3357     3363       +6     
  Branches      757      760       +3     
==========================================
+ Hits         3335     3340       +5     
+ Misses         21       19       -2     
- Partials        1        4       +3     
Impacted Files Coverage Δ
src/operators/expression/date/dateToString.ts 100.00% <100.00%> (ø)
src/operators/expression/date/dateFromParts.ts 96.87% <0.00%> (-3.13%) ⬇️
src/lazy.ts 96.24% <0.00%> (ø)
src/operators/pipeline/sort.ts 95.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b70467e...833b15e. Read the comment docs.

Copy link
Owner

@kofrasa kofrasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bug probably due to auto import from the code editor. The code is supposed to be calling assert from the util module.

@cezarcarvalhaes
Copy link
Contributor Author

@kofrasa Ahh, I see. I pushed the changes.

@kofrasa kofrasa merged commit 1436b72 into kofrasa:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importing assert from console in dateToString causes usage with Webpack v5 to break
2 participants