Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing assert from console in dateToString causes usage with Webpack v5 to break #225

Closed
cezarcarvalhaes opened this issue Feb 2, 2022 · 1 comment · Fixed by #226

Comments

@cezarcarvalhaes
Copy link
Contributor

Using mingo v6+ in an app built with webpack throws an error: Module not found: Error: Can't resolve 'console' in....

Webpack also includes the message: BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. This is no longer the case. Verify if you need this module and configure a polyfill for it.

This is caused by importing assert from console in dateToString.ts and can be fixed by simply calling console.assert directly. A pull request for this is coming shortly.

@kofrasa
Copy link
Owner

kofrasa commented Feb 2, 2022

Thanks @cezarcarvalhaes. Actually the code should be calling assert from the util module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants