Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6489 padding #6493

Merged
merged 4 commits into from
Aug 3, 2023
Merged

#6489 padding #6493

merged 4 commits into from
Aug 3, 2023

Conversation

prachi00
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
Screen Shot 2023-07-29 at 4 55 06 PM

Copilot Summary

@prachi00 prachi00 requested a review from a team as a code owner July 29, 2023 23:55
@prachi00 prachi00 requested review from roiLeo and vikiival and removed request for a team July 29, 2023 23:55
@kodabot
Copy link
Collaborator

kodabot commented Jul 29, 2023

SUCCESS @prachi00 PR for issue #6489 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6ee1101
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64caa82e3c42a30007f40911
😎 Deploy Preview https://deploy-preview-6493--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 29, 2023

AI-Generated Summary: This pull request pertains to a minor change in the layout styling for a Vue.js application. The styling changes involve modification to a div container class within the default.vue file. The 'container is-fluid' class is updated to incorporate zero padding by appending 'p-0' to the existing class. This adjustment ensures that the div container stretches to fill the horizontal space of its parent container without any padding.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 29, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comes from #6457, landing page should be using 'full-width-layout'

@prachi00
Copy link
Member Author

prachi00 commented Aug 1, 2023

Comes from #6457, landing page should be using 'full-width-layout'

@roiLeo what do you mean?

@roiLeo
Copy link
Contributor

roiLeo commented Aug 1, 2023

@prachi00 you should use full-width-layout on landing page and it will fix this issue. Check old code before vue3 migration on the page.

@prachi00
Copy link
Member Author

prachi00 commented Aug 2, 2023

@prachi00 you should use full-width-layout on landing page and it will fix this issue. Check old code before vue3 migration on the page.

done

@prachi00 prachi00 requested a review from roiLeo August 2, 2023 16:55
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm ✅

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 2, 2023
@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Aug 2, 2023
@prury
Copy link
Member

prury commented Aug 2, 2023

it affected other elements as well:
image

image

@codeclimate
Copy link

codeclimate bot commented Aug 2, 2023

Code Climate has analyzed commit 6ee1101 and detected 0 issues on this pull request.

View more on Code Climate.

@prachi00
Copy link
Member Author

prachi00 commented Aug 2, 2023

it affected other elements as well: image

image

@roiLeo I guess the previous fix was better then?

@roiLeo
Copy link
Contributor

roiLeo commented Aug 2, 2023

it affected other elements as well:

Are you sure it is related with this PR? Looks weird as I can only see changes related to landing page

@prury
Copy link
Member

prury commented Aug 2, 2023

it affected other elements as well:

Are you sure it is related with this PR? Looks weird as I can only see changes related to landing page

i don't know what the heck happened, i opened again now and its working properly
checked all the other PRs to see if was one of them and found nothing

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Aug 2, 2023
@prachi00
Copy link
Member Author

prachi00 commented Aug 3, 2023

it affected other elements as well:

Are you sure it is related with this PR? Looks weird as I can only see changes related to landing page

i don't know what the heck happened, i opened again now and its working properly checked all the other PRs to see if was one of them and found nothing

um okay with me 😂

@vikiival vikiival merged commit 0f605f3 into main Aug 3, 2023
@vikiival vikiival deleted the feat-padding-landing branch August 3, 2023 19:06
This was referenced Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

landing page container content not lined up
5 participants