Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuxt-propert-decorator/more-pages #6457

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Jul 22, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Pages in this PR

  1. home page
  2. snek/assets
  3. snek/claim
  4. snek/incomingOffers
  5. snek/offers
  6. snek/stats
  7. stmn/waifu

desired outcome

no change in look and/or behavior

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at e768e96

This pull request streamlines the user interface and code structure of the snek NFT minting and trading features. It moves the claim, generative mint, asset, offer, and stats pages to the home page and simplifies the component syntax. It also renames some components and files to avoid confusion.

🤖 Generated by Copilot at e768e96

We've moved the pages to the index, me hearties
We've simplified the syntax of the Component
We've streamlined the snek NFT experience
So heave away and pull the code with confidence

@daiagi daiagi requested a review from a team as a code owner July 22, 2023 04:45
@daiagi daiagi requested review from roiLeo and vikiival and removed request for a team July 22, 2023 04:45
@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e768e96
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64bb5ef7ec74800008ad1289
😎 Deploy Preview https://deploy-preview-6457--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 22, 2023

AI-Generated Summary: This pull request includes changes to multiple Vue components. In particular, it removes the usage of the @Component decorator and explicit class components, instead shifting towards Vue's Composition API for defining components in seven different files: 'index.vue', 'assets.vue', 'claim.vue', 'incomingOffers.vue', 'offers.vue', 'stats.vue', and 'waifu.vue'. This modification streamlines the code by reducing the number of imports and function calls, which may result in improved readability and simplicity.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 22, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 22, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Jul 22, 2023

Code Climate has analyzed commit e768e96 and detected 0 issues on this pull request.

View more on Code Climate.

@prury
Copy link
Member

prury commented Jul 23, 2023

index.vue - ok
assets page: ok (unrelated: assets taking a long time to fetch balances today)
claim page: we don't really use it atm - ok
incoming offers: ok
offers: ok
stats: ok
waifu: ok

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 23, 2023
@vikiival vikiival merged commit 1807757 into main Jul 24, 2023
@vikiival vikiival deleted the nuxt-propert-decorator/more-pages branch July 24, 2023 08:49
This was referenced Jul 25, 2023
@roiLeo roiLeo mentioned this pull request Jul 31, 2023
7 tasks
This was referenced Aug 2, 2023
This was referenced Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants