Active Coveralls on Pull Requests

[OlivierCavadenti]

• Active existing coveralls Github Action on pull requests to have code coverage control (avoid no covered code)

[OlivierCavadenti]

@kibertoad It seems coverall bot dont leave comment on the PR, can you check this ?
https://javascript.plainenglish.io/enable-coveralls-to-leave-comments-on-prs-4c88fbeee363

EDITI : it seems it's not possible from forked repo : coverallsapp/github-action#7

[OlivierCavadenti]

@kibertoad
I made some tests, and it seems at this time it will be difficult to automate posting comments on PR with coveralls (write permissions issue), it's not so important by the way.
One thing I will like by the way is to have a failing job when code coverage drop.

I intentionnaly drop the code coverage by skip some tests, but it seems the job is already green.
Can you check in the repo settings of Coveralls if they are any threshold for coverage decrease and remove it ?

[kibertoad]

Sorry for delay, will take a l9ok tomorrow

[kibertoad]

I've set threshold for change to 0.0

[OlivierCavadenti]

Coveralls job still green, but it seems an issue : lemurheavy/coveralls-public#1623

[OlivierCavadenti]

Can remove threshold by blank the input instead of put 0.0 plz ? @kibertoad

[kibertoad]

@OlivierCavadenti done

[kibertoad]

[OlivierCavadenti]

It's possible to send me credentials for Coveralls by mail ? I will tests some configuration tomorrow.

[kibertoad]

@OlivierCavadenti Try using github account for auth, if you can't see knex repo there, I'll add permissions

[OlivierCavadenti]

@kibertoad I can connect and I see project but I can't modify anything

[kibertoad]

@OlivierCavadenti Can you try now?

[OlivierCavadenti]

@OlivierCavadenti Can you try now?

it's ok now thanks !

[OlivierCavadenti]

Seems coverage decrease don't work but it seems to be useful to have the coverage on each pull request anyway. I will check later if I finally can fix this...