Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No PR Comment when there is PR from forked repo #7

Closed
ibakshay opened this issue Sep 27, 2019 · 7 comments
Closed

No PR Comment when there is PR from forked repo #7

ibakshay opened this issue Sep 27, 2019 · 7 comments

Comments

@ibakshay
Copy link
Contributor

Hi,

The Pull Request comment is not posted from Coveralls when there is a PR from the forked repository. Could you please look into the issue ?

Thanks in advance.
@IOrlandoni
Copy link

Same issue. Sample links:

Yet... no comment or check is posted to the pull request.

@IOrlandoni IOrlandoni mentioned this issue Nov 12, 2019
Closed
@IOrlandoni
Copy link

@nickmerwin Any chance you could check this issue? It seems to me like a must-have for open source projects where work is done on forks and pull-requested in.

@IOrlandoni IOrlandoni mentioned this issue Nov 21, 2019
Closed
@a-b-r-o-w-n
Copy link

@dunning-kruger @ibakshay This is likely due to the fact that the github token is read-only for forked pull requests. https://help.github.com/en/actions/automating-your-workflow-with-github-actions/authenticating-with-the-github_token#permissions-for-the-github_token

@IOrlandoni
Copy link

@a-b-r-o-w-n Attempting to work-around this by creating a specific token and passing that to the action... do you know which permissions does coveralls require?

@a-b-r-o-w-n
Copy link

Github will not share any user secrets for forked repos. ${{ secrets.GITHUB_TOKEN }} that is shared is a read-only token and cannot post PR comments. So there is no workaround as far as I know.

@Shylock-Hg Shylock-Hg mentioned this issue Jan 9, 2020
Closed
@bitsf
Copy link

bitsf commented Feb 11, 2020

I have the same problem, so this is the dead path right?
But why travis can post back comment?

@sindresorhus sindresorhus mentioned this issue Feb 12, 2020
Merged
@LPGhatguy LPGhatguy mentioned this issue Mar 25, 2020
Merged
@Can-Sahin
Copy link

So any open source projects using coveralls github actions cannot get their pull requests checked? Seems a big killer for me. Status check is stuck now

@Can-Sahin Can-Sahin mentioned this issue Apr 30, 2020
Closed
@siku2 siku2 mentioned this issue Jun 15, 2020
Closed
@xTVaser xTVaser mentioned this issue Sep 8, 2020
Merged
@henryiii henryiii mentioned this issue Jan 17, 2021
Merged
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 19, 2021
@avtikhon
github-ci: add result message from coveralls in PR
3d6fa36 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 19, 2021
@avtikhon
github-ci: add result message from coveralls in PR
a3ff7f5 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 19, 2021
@avtikhon
github-ci: add result message from coveralls in PR
f67478a 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
@avtikhon avtikhon mentioned this issue Mar 19, 2021
Merged
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 19, 2021
@avtikhon
github-ci: add result message from coveralls in PR
77e9b80 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 19, 2021
@avtikhon
github-ci: add result message from coveralls in PR
9f10e4d 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 19, 2021
@avtikhon
github-ci: add result message from coveralls in PR
e5012d9 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 21, 2021
@avtikhon
github-ci: add result message from coveralls in PR
faff43f 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 21, 2021
@avtikhon
github-ci: add result message from coveralls in PR
779e4f6 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 21, 2021
@avtikhon
github-ci: add result message from coveralls in PR
c7be50d 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38

t
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 22, 2021
@avtikhon
github-ci: add result message from coveralls in PR
c8a1d35 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 22, 2021
@avtikhon
github-ci: add result message from coveralls in PR
c7e762f 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 22, 2021
@avtikhon
github-ci: add result message from coveralls in PR
ca39a5d 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 22, 2021
@avtikhon
github-ci: add result message from coveralls in PR
5abd90b 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 22, 2021
@avtikhon
github-ci: add result message from coveralls in PR
1e7bd37 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

To avoid of issue coverallsapp/github-action#55 [2], sources checkout
should be based on 2nd version and later, to support it newer docker
image is used tarantool/testing:debian-buster.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
[2]: coverallsapp/github-action#55 (comment)
avtikhon added a commit to tarantool/tarantool that referenced this issue Mar 22, 2021
@avtikhon
github-ci: add message in PR with coveralls link
ff7aa46 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

To avoid of issue coverallsapp/github-action#55 [2], sources checkout
should be based on 2nd version and later, to support it newer docker
image is used tarantool/testing:debian-buster.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
[2]: coverallsapp/github-action#55 (comment)
avtikhon added a commit to tarantool/tarantool that referenced this issue May 13, 2021
@avtikhon
github-ci: add message in PR with coveralls link
b1d2161 
Workflow 'debug_coverage' produces and uploads results to 'coveralls.io'
web site. Message about it can be shown in PR within each run was done.
This patch adds the ability to send message in available PR otherwise it
is skipped. Also added 'coverage.info' file to artifacts list.

Found that used 'coverallsapp/github-action' action checks if the
trigger was 'pull_request' used to run the workflow. And only in this
way it writes results message to PR. Previously 'pull_request' trigger
was blocked to avoid duplication with 'push' trigger. To make able to
run workflow by any single trigger and to send message to PR if it
exits, it was implemented the following logic:

  - run workflows on both triggers 'push' and 'pull_request';
  - for workflow with 'push' trigger check if PR exists then skip all
    jobs otherwise continue running;
  - for workflow with 'pull_request' trigger continue running;

Also found that due to opened issue coverallsapp/github-action#7 this
action is not currently ready to post results to github PR. Added
workaround, local print of message to PR with link to 'coveralls.io'
with results of the current branch.

To avoid of issue coverallsapp/github-action#55 [2], sources checkout
should be based on 2nd version and later, to support it newer docker
image is used tarantool/testing:debian-buster.

Closes #5644

[1]: https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L38
[2]: coverallsapp/github-action#55 (comment)
@OlivierCavadenti OlivierCavadenti mentioned this issue Mar 25, 2022
Merged
@BAStos525 BAStos525 mentioned this issue Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bitsf @IOrlandoni @a-b-r-o-w-n @Can-Sahin @ibakshay