Case convention inconsistent in Knative Serving config maps

[mgencur]

Some config maps have keys using camel-case, some have kebab-case. The majority of the config maps use camel-case at this point. All of this should probably be unified.

camel-case used in these config maps:

• config-deployment
• config-leader-election
• config-network

Expected Behavior

All config maps using the same notation.

Actual Behavior

Some config maps using a different notation than others.

Steps to Reproduce the Problem

[vagababov]

ugh, that ship has sailed probably... otherwise it's a long and painful migration. :|

[julz]

I wonder if now that we have the nice config map parsing library in pkg we could make this change in a backwards compatible way without a completely unreasonable amount of pain 🤔. It's only going to worse if we don't so I vote we bite the bullet, fwiw.

Hyphens ftw ;).

[mattmoor]

Another alternative is @markusthoemmes proposal to switch to CRDs. Care to link that?

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[mattmoor]

/lifecycle frozen

Ping @markusthoemmes for link

[markusthoemmes]

#8114 here's the other issue.

[evankanderson]

I think #8114 is probably the best chance to resolve this issue.

/area API

/close

[knative-prow-robot]

@evankanderson: Closing this issue.

In response to this:

I think #8114 is probably the best chance to resolve this issue.

/area API

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dprotaso]

if now that we have the nice config map parsing library in pkg we could make this change in a backwards compatible way without a completely unreasonable amount of pain 🤔. It's only going to worse if we don't

I think for the 1.0 efforts we should do this and keeping the backwards compatible

/reopen
/assign @dprotaso

[knative-prow-robot]

@dprotaso: Reopened this issue.

In response to this:

if now that we have the nice config map parsing library in pkg we could make this change in a backwards compatible way without a completely unreasonable amount of pain 🤔. It's only going to worse if we don't

I think for the 1.0 efforts we should do this and keeping the backwards compatible

/reopen
/assign @dprotaso

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cardil]

I've just filled a similar issue to track label and annotation names as well - #12103

I think, those two should be done in synchronization to lower the migration pain for end users.

[dprotaso]

I think all the config maps are sorted and the documentation was the last remaining bit