Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change casing to be consistent with serving #522

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 1, 2021

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 1, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #522 (881b5bd) into main (749575e) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
+ Coverage   95.34%   95.43%   +0.08%     
==========================================
  Files          37       37              
  Lines         774      788      +14     
==========================================
+ Hits          738      752      +14     
  Misses         25       25              
  Partials       11       11              
Impacted Files Coverage Δ
pkg/network.go 87.09% <100.00%> (+1.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749575e...881b5bd. Read the comment docs.

@dprotaso
Copy link
Member Author

dprotaso commented Oct 1, 2021

since Markus commented on the other PRs

/assign @markusthoemmes

@dprotaso
Copy link
Member Author

dprotaso commented Oct 7, 2021

/assign @julz

@nak3
Copy link
Contributor

nak3 commented Oct 8, 2021

As serving repo changed knative/serving#12071, this PR should go as well?

Copy link
Member

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from typo-ed old field name

pkg/network_test.go Outdated Show resolved Hide resolved
Copy link
Member

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, julz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants