-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change casing to be consistent with serving #522
Conversation
Codecov Report
@@ Coverage Diff @@
## main #522 +/- ##
==========================================
+ Coverage 95.34% 95.43% +0.08%
==========================================
Files 37 37
Lines 774 788 +14
==========================================
+ Hits 738 752 +14
Misses 25 25
Partials 11 11
Continue to review full report at Codecov.
|
since Markus commented on the other PRs /assign @markusthoemmes |
/assign @julz |
As serving repo changed knative/serving#12071, this PR should go as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm apart from typo-ed old field name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, julz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of: knative/serving#7300