[WIP] Registry - Proposal / Initial Version #977

nachocano · 2019-03-26T22:45:25Z

First cut for the Registry feature request: #929

Proposed Changes

Registry per Namespace (i.e., EventTypes are namespaced).
Broker Ingress Policies can be configured with boolean values: allowAny, autoAdd.
RBAC permissions for ingress to retrieve and create EventTypes on the Broker ingress.
EventType Controller that not only watches for EventTypes but also for Broker changes in order to update the EventType Readiness status.

Release Note

EventConsumers can now query the Registry to see what event types can be consumed from the eventing mesh.

Broker unit tests.

Trigger filters on event source and type

spec is immutable.

…dType. Add unit tests for the filter binary.

Rename Trigger.Spec.Filter.ExactMatch to Trigger.Spec.Filter.SourceAndType. Add unit tests for the filter binary.

With this we allow to reconcile only the triggers that belong to the particular broker that changed

Reconcile Triggers on Broker changes.

Trigger controller UTs

…eAccount and RBAC. Sadly this doesn't work well because we have such an old version of controller-runtime that the Filter ends up trying to watch _all_ Triggers, not just those in its namespace. And it only gets permission for the Triggers in its own namespace.

Should be implemented

Broker and trigger types UTs

…r-e2e

# Conflicts: # cmd/broker/ingress/main.go

docs/registry/README.md

# Conflicts: # Gopkg.lock

nachocano · 2019-04-11T16:36:23Z

/retest

nachocano · 2019-04-11T17:29:23Z

/retest

knative-prow-robot · 2019-04-17T17:28:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nachocano
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: grantr

If they are not already assigned, you can assign the PR to them by writing /assign @grantr in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# Conflicts: # cmd/controller/main.go # pkg/reconciler/v1alpha1/namespace/namespace.go # pkg/reconciler/v1alpha1/namespace/namespace_test.go

knative-prow-robot · 2019-04-25T20:12:23Z

@nachocano: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-knative-eventing-unit-tests	`b69f643`	link	`/test pull-knative-eventing-unit-tests`
pull-knative-eventing-build-tests	`b69f643`	link	`/test pull-knative-eventing-build-tests`
pull-knative-eventing-integration-tests	`b69f643`	link	`/test pull-knative-eventing-integration-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

knative-metrics-robot · 2019-04-25T20:13:35Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/eventing/v1alpha1/eventtype_defaults.go	Do not exist	100.0%
pkg/apis/eventing/v1alpha1/eventtype_lifecycle.go	Do not exist	100.0%
pkg/apis/eventing/v1alpha1/eventtype_validation.go	Do not exist	94.7%
pkg/broker/ingress.go	Do not exist	96.3%
pkg/broker/receiver.go	82.9%	83.9%	1.0
pkg/broker/ttl.go	Do not exist	100.0%

nachocano · 2019-04-26T16:48:13Z

Closing as it has been split into the design #1015 and implementation #1105 PRs.
Note the 90 PRs in between until an agreement was made :)

Signed-off-by: Matthias Wessendorf <[email protected]>

Co-authored-by: serverless-qe <[email protected]>

nachocano and others added 30 commits February 13, 2019 13:38

Attempt to reconcile broker in trigger controller

e75141c

Broker controller unit tests.

e79b8f7

Merge pull request #9 from Harwayne/broker-test

ae665bd

Broker unit tests.

Merge remote-tracking branch 'broker/broker-new-model' into broker-new

af2f475

Merge pull request #4 from nachocano/filter-exp

dbe650a

Trigger filters on event source and type

Deleting and re-creating subscription object as the backing channel

30f1c74

spec is immutable.

Merge remote-tracking branch 'broker/broker-new-model' into broker-new

f363e02

Adding comment

e45d19a

Rename Trigger.Spec.Filter.ExactMatch to Trigger.Spec.Filter.SourceAn…

1628333

…dType. Add unit tests for the filter binary.

Merge pull request #11 from Harwayne/filter-test

a6d2650

Rename Trigger.Spec.Filter.ExactMatch to Trigger.Spec.Filter.SourceAndType. Add unit tests for the filter binary.

Merge remote-tracking branch 'broker/broker-new-model' into broker-new

434bf9d

Adding event messages

cbbd066

Using the broker's namespacedNamed as key to the triggers map.

c33c569

With this we allow to reconcile only the triggers that belong to the particular broker that changed

Merge pull request #10 from nachocano/broker-new

66f6f44

Reconcile Triggers on Broker changes.

Adding some tests to trigger

40ca8da

More UTs

650ef47

More UTs

d2c1ef8

More UTs

ae04007

Merge pull request #12 from nachocano/broker-new-trigger-ut

6d6c488

Trigger controller UTs

Remove no longer needed label.

3ad193f

Broker and trigger types UTs

d18acab

WIP early E2E test

2a02ba5

Changes after code review. Adding trigger defaults and validation tests

54cdb3c

Cleaner trigger validation

11a1734

Adding dummy tests for broker validation...

d713eeb

Should be implemented

Merge pull request #14 from nachocano/broker-new-trigger-ut

89cdd58

Broker and trigger types UTs

Merge remote-tracking branch 'grantr/broker-new-model-e2e' into broke…

bd4345a

…r-e2e

Compiling and moving things around

49fd1a0

Updating test

4cdfd58

nachocano added 2 commits March 29, 2019 14:46

Merge remote-tracking branch 'upstream/master' into broker-new-model

b68e7e0

# Conflicts: # cmd/broker/ingress/main.go

Merge remote-tracking branch 'upstream/master' into broker-new-model

47997a8

nachocano mentioned this pull request Apr 1, 2019

Registry Design #1015

Merged

daisy-ycguo reviewed Apr 2, 2019

View reviewed changes

nachocano added 7 commits April 5, 2019 13:26

Merge remote-tracking branch 'upstream/master' into broker-new-model

5adb2c3

# Conflicts: # Gopkg.lock

update README with other branch

7741e18

Merge remote-tracking branch 'upstream/master' into broker-new-model

868d834

updating e2e tests

bc3236b

Updating deepcopy

f0ce511

naming changes

d341ab2

disabling registry test to see if this is causing problems

06f98cf

nachocano added 2 commits April 11, 2019 13:31

re-enabling these guys again

00cd8e2

Merge remote-tracking branch 'upstream/master' into broker-new-model

004b28a

nachocano added 8 commits April 24, 2019 16:22

Merging upstream/master

7d5da5f

Missing files

b324794

Merge remote-tracking branch 'upstream/master' into registry-new-model

c38c663

# Conflicts: # cmd/controller/main.go # pkg/reconciler/v1alpha1/namespace/namespace.go # pkg/reconciler/v1alpha1/namespace/namespace_test.go

adding description

82f3921

removing autoAdd

1a4ab08

some updates, still broken

f0df342

Merge remote-tracking branch 'upstream/master' into broker-new-model

9d46b79

some updates, still broken

b69f643

nachocano closed this Apr 26, 2019

lberk pushed a commit to lberk/eventing that referenced this pull request Nov 17, 2020

unset OPENSHIFT_CI (knative#977)

afe2bf9

Signed-off-by: Matthias Wessendorf <[email protected]>

creydr pushed a commit to creydr/knative-eventing that referenced this pull request Dec 11, 2024

[release-v1.15] Sync Konflux configurations (knative#977)

e0039ee

Co-authored-by: serverless-qe <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Registry - Proposal / Initial Version #977

[WIP] Registry - Proposal / Initial Version #977

nachocano commented Mar 26, 2019

nachocano commented Apr 11, 2019

nachocano commented Apr 11, 2019

knative-prow-robot commented Apr 17, 2019

knative-prow-robot commented Apr 25, 2019 •

edited

Loading

knative-metrics-robot commented Apr 25, 2019

nachocano commented Apr 26, 2019

[WIP] Registry - Proposal / Initial Version #977

[WIP] Registry - Proposal / Initial Version #977

Conversation

nachocano commented Mar 26, 2019

Proposed Changes

nachocano commented Apr 11, 2019

nachocano commented Apr 11, 2019

knative-prow-robot commented Apr 17, 2019

knative-prow-robot commented Apr 25, 2019 • edited Loading

knative-metrics-robot commented Apr 25, 2019

nachocano commented Apr 26, 2019

knative-prow-robot commented Apr 25, 2019 •

edited

Loading