Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Registry #1105

Merged
merged 330 commits into from
Apr 26, 2019
Merged

Event Registry #1105

merged 330 commits into from
Apr 26, 2019

Conversation

nachocano
Copy link
Contributor

@nachocano nachocano commented Apr 25, 2019 •
edited
Loading

first step towards #929

Proposed Changes

  • Adding an EventType-namespaced CRD with immutable fields but the description.
  • Adding an EventType Controller that watches for EventTypes and tracks changes to the Broker to update the EventType's readiness status based on the Broker status.

Release Note

New EventType CRD available to store the event types that can be consumed from the eventing mesh.

nachocano and others added 30 commits February 14, 2019 14:44
@nachocano
Adding some tests to trigger
40ca8da
@nachocano
More UTs
650ef47
@nachocano
More UTs
d2c1ef8
@nachocano
More UTs
ae04007
@Harwayne
Merge pull request #12 from nachocano/broker-new-trigger-ut
6d6c488 
Trigger controller UTs
@Harwayne
Namespace reconciler automatically creates the Broker Filter's Servic…
9c63dbc 
…eAccount and RBAC.

Sadly this doesn't work well because we have such an old version of controller-runtime that the Filter ends up trying to watch _all_ Triggers, not just those in its namespace. And it only gets permission for the Triggers in its own namespace.
@Harwayne
Remove no longer needed label.
3ad193f
@nachocano
Broker and trigger types UTs
d18acab
@grantr
WIP early E2E test
2a02ba5
@nachocano
Changes after code review. Adding trigger defaults and validation tests
54cdb3c
@nachocano
Cleaner trigger validation
11a1734
@nachocano
Adding dummy tests for broker validation...
d713eeb 
Should be implemented
@Harwayne
Merge pull request #14 from nachocano/broker-new-trigger-ut
89cdd58 
Broker and trigger types UTs
@nachocano
Merge remote-tracking branch 'grantr/broker-new-model-e2e' into broke…
bd4345a 
…r-e2e
@nachocano
Compiling and moving things around
49fd1a0
@nachocano
Updating test
4cdfd58
@nachocano
More updates
b42d359
@nachocano
Waiting for potentially multiple contents.
29be515 
Removing check for corev1.Service ready.
Removing grant's great design. Just making it simpler for now.
@nachocano
Compiling
1edbf0a
@nachocano
Fixing compilation
9c415e6
@nachocano
Fixing compilation errors. Adding AnnotateNamespace function.
ac9b485
@nachocano
Adding ns
2b39168
@nachocano
Adding logs. Changing to lowercase any otherwise the pod name is invalid
ed9fcbe
@nachocano
Removing namespace when creating trigger subscriber spec.
4848952 
Adding wait time constant for default broker creation.
@nachocano
Checking if all triggers are ready
311e174
@nachocano
Updated logs
d361afb
@nachocano
Working
d1198a9
@nachocano
Adding logs... Still not receiving the events.
6bd659c
@nachocano
More logs
0d80f9c
@nachocano
Adding build constraint
cd862ff
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 25, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 25, 2019
@nachocano
Copy link
Contributor Author

/cc @vaikas-google @grantr @Harwayne

@nachocano
Copy link
Contributor Author

/test pull-knative-eventing-integration-tests

@nachocano
Copy link
Contributor Author

/test pull-knative-eventing-integration-tests

@chaodaiG
Copy link
Contributor

/retest
just in case this was caused by Prow outage

@vaikas
Copy link
Contributor

vaikas commented Apr 26, 2019

Just saw you made the change to watch the broker :) Was going to suggest that, so great!!! Please remove the TODO, should watch for Broker changes as well... from the description.

@vaikas
Copy link
Contributor

vaikas commented Apr 26, 2019

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/eventtype_defaults.go Do not exist 100.0%
pkg/apis/eventing/v1alpha1/eventtype_lifecycle.go Do not exist 100.0%
pkg/apis/eventing/v1alpha1/eventtype_validation.go Do not exist 95.7%
pkg/reconciler/eventtype/eventtype.go Do not exist 77.4%
pkg/reconciler/trigger/trigger.go Do not exist 83.6%

@knative-prow-robot knative-prow-robot merged commit 54500a2 into knative:master Apr 26, 2019
@nachocano nachocano mentioned this pull request Apr 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@matzew matzew Awaiting requested review from matzew

@grantr grantr Awaiting requested review from grantr

@Harwayne Harwayne Awaiting requested review from Harwayne

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nachocano @chaodaiG @vaikas @knative-prow-robot @knative-metrics-robot @googlebot @Harwayne @grantr