Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added title/aliases to rendor the document #2587

Closed
wants to merge 1 commit into from
Closed

Added title/aliases to rendor the document #2587

wants to merge 1 commit into from

Conversation

mpetason
Copy link
Contributor

@mpetason mpetason commented Jun 15, 2020 •
edited
Loading

#2586

  • It looks like the block at the top of the README was lost between 0.14
    and 0.15. Added the block back.

I think this is what fixes the issues with the tabs being rendered since it is on other files and got dropped for this version.

Added title/aliases to rendor the document
e29140f 
- Fixes knative#2586
- It looks like the block at the top of the README was lost between 0.14
and 0.15. Added the block back.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 15, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 15, 2020
@abrennan89
Copy link
Contributor

/assign @evankanderson
I'm still not great with aliases 🙂 can you check this please Evan?

@evankanderson
Copy link
Member

This should covered by: https://github.com/knative/docs/blob/e29140f703d678ac4022e072c654632302a667ce/docs/eventing/samples/ping-source/index.md

@mpetason
Copy link
Contributor Author

What is causing it to not be rendered correctly in the linked issue?

@abrennan89
Copy link
Contributor

@evankanderson aha, got you. Can this PR be closed then if it's just duplicating that?

@evankanderson
Copy link
Member

Ah, it may be that tabs and readfile aren't working together. I'll see if I can figure that out in website.

@mpetason
Copy link
Contributor Author

@evankanderson Want me to close this since it will prob be fixed in the website repository?

n3wscott
n3wscott reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mpetason, n3wscott
To complete the pull request process, please assign evankanderson
You can assign the PR to them by writing /assign @evankanderson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@n3wscott
Copy link
Contributor

whoops

/hold

Did not read the commends, just the PR.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@mpetason
Copy link
Contributor Author

Closing this issue since the fixes are going to be in Website.

@mpetason mpetason closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@evankanderson evankanderson

@n3wscott n3wscott

Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mpetason @abrennan89 @evankanderson @knative-prow-robot @n3wscott @googlebot