Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PingSource Sample Not Rendering Tabs Correctly for v0.15.0 Docs #2586

Closed
danielhelfand opened this issue Jun 15, 2020 · 6 comments
Closed

PingSource Sample Not Rendering Tabs Correctly for v0.15.0 Docs #2586

danielhelfand opened this issue Jun 15, 2020 · 6 comments
Assignees
@evankanderson
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/critical
Milestone
v0.17.0

Comments

@danielhelfand
Copy link
Contributor

Expected Behavior

Tables and associated tabs render correctly for the website as with v0.14.0 docs: https://knative.dev/v0.14-docs/eventing/samples/ping-source/

Actual Behavior

Tables and associated tabs not rendering: https://knative.dev/docs/eventing/samples/ping-source/

Additional Info

Only change from v0.14.0 I noticed was #2377. Not sure if anything in the pr caused the change, or if additional docs would also be affected.
@danielhelfand danielhelfand added the kind/bug Categorizes issue or PR as related to a bug. label Jun 15, 2020
mpetason pushed a commit to mpetason/docs that referenced this issue Jun 15, 2020
Added title/aliases to rendor the document
e29140f 
- Fixes knative#2586
- It looks like the block at the top of the README was lost between 0.14
and 0.15. Added the block back.
@mpetason mpetason mentioned this issue Jun 15, 2020
Closed
@abrennan89
Copy link
Contributor

@evankanderson can you please take a look at this - I'm not sure if the other PR that you merged caused something in the tabs to break? 🙂

@lionelvillard
Copy link
Member

same issue with this page: https://knative.dev/development/eventing/sources/

@abrennan89 abrennan89 added this to the 0.17 docs release milestone Jul 10, 2020
@abrennan89
Copy link
Contributor

#2680 by @lionelvillard fixes this issue.
Needs to be cherrypicked into 0.15, 0.16

@lionelvillard
Copy link
Member

for the record, shortcodes don't get processed by readFile.

@lionelvillard
Copy link
Member

Apparently there is a workaround by using GetPage: https://discourse.gohugo.io/t/readfile-does-not-parse-shortcodes/16667/7

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen.Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2020
@github-actions github-actions bot closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evankanderson evankanderson

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/critical
Projects
None yet
Milestone
v0.17.0
Development

No branches or pull requests
4 participants
@lionelvillard @evankanderson @danielhelfand @abrennan89