fix README for community Dart sample #1180
Conversation
Replace pubspec field `private` with `publish_to`. [ref](https://www.dartlang.org/tools/pub/pubspec#publish_to) See @52f464f.
knative-prow-robot
added
the
size/XXL
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
knative-prow-robot
added
the
needs-ok-to-test
knative-prow-robot
added
size/XS
|
/ok-to-test |
knative-prow-robot
removed
the
needs-ok-to-test
|
@mockturtl Please see the bot's comment about signing the CLA. If you think you already have, the most common issue with the CLA bot is the email used to sign your git commits being different from the email you used to sign the CLA. As soon as that's resolved, we'll get this merged in. |
|
Hi @samodell, thanks! I've signed the CLA (The good news is that everyone that needs to sign a CLA ... have done so. Everything is all good there). I think the bot was tripped because I targeted my patch for the I fixed that...
...so the PR no longer includes other people's code (it appears that one or more commits were authored or co-authored by someone other than the pull request submitter). |
|
Ah, that's what I get for skimming. I'll override the CLA bot, then. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mockturtl, samodell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
samodell
added
cla: yes
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Replace pubspec field `private` with `publish_to`. [ref](https://www.dartlang.org/tools/pub/pubspec#publish_to) See @52f464f.
* Knative with Gardener - Fix Installing Istio Typo (#1027) * Update installation documentation with Minishift (#1114) * Remove usage of kubectl. Using oc instead * Update webhook admissions * Mention IKS's one-click install process (#1131) Signed-off-by: Doug Davis <[email protected]> * helloworld-go: install CA certs (#1143) * helloworld-go: install CA certs All users who are querying any HTTPS endpoints will need this and won't understand why it's failing. * address fixes Signed-off-by: Ahmet Alp Balkan <[email protected]> * Use istio-ingressgateway servce as this is the new one used in Knative 0.3 and above (#1171) * knative.slack.com -> slack.knative.dev (#1176) * Update Knative-custom-install.md (#1178) change the name `release.yaml` to `build.yaml` * fix README (#1180) Replace pubspec field `private` with `publish_to`. [ref](https://www.dartlang.org/tools/pub/pubspec#publish_to) See @52f464f.
Replace pubspec field
privatewithpublish_to.See 52f464f.
ref